mistercrunch commented on code in PR #31315:
URL: https://github.com/apache/superset/pull/31315#discussion_r1873861623
##########
superset/models/core.py:
##########
@@ -691,27 +731,30 @@ def _log_query(sql: str) -> None:
with self.get_raw_connection(catalog=catalog, schema=schema) as conn:
Review Comment:
> WDYT about introducing the temporarily_disconnect_db logic inside
get_raw_connection
Unfortunately I don't think that it is possible, given that
`get_raw_connection` is context manager, and that it's possible for the caller
to use the metadata database in the context provided by the context manager...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
