glothriel commented on code in PR #30956:
URL: https://github.com/apache/superset/pull/30956#discussion_r1875502912


##########
helm/superset/templates/init-job.yaml:
##########
@@ -37,6 +41,9 @@ spec:
       {{- if .Values.init.podAnnotations }}
       annotations: {{- toYaml .Values.init.podAnnotations | nindent 8 }}
       {{- end }}
+      {{- if .Values.init.podLabels }}
+      labels: {{- toYaml .Values.init.podLabels | nindent 8 }}
+      {{- end }}

Review Comment:
   I noticed that but it was unclear to me if only the Job should receive the 
labels or the child pod should still get them. Anyway, the last commits adds 
that.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to