rusackas commented on PR #31331: URL: https://github.com/apache/superset/pull/31331#issuecomment-2528841014
This seems like a reasonable feature, but leaves me with a couple of questions: 1) I defer to @yousoph / @eschutho to assign a reviewer who might have a good embedded test setup. We need to figure out who are the best owners/reviewers for Embedded SDK changes, going forward. 2) Regarding the feature flag, do you think we need to have a flag at all? Do you perceive a risk (security or otherwise) that would warrant people disabling it? 3) If it's to be configurable, should the config happen at the Superset level, or can it be contained as part of the SDK itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
