sowo commented on PR #28203: URL: https://github.com/apache/superset/pull/28203#issuecomment-2535476280
turns out there was an issue in query_context_processor. Tests are passing now. On Tue, Dec 10, 2024 at 10:12 PM Wolfgang Sommerer < ***@***.***> wrote: > as far as I can tell, all test failures complain about missing strftime. > (either "AttributeError: 'numpy.float64' object has no attribute > 'strftime'" or "AttributeError: 'str' object has no attribute 'strftime'"). > I don't think the changes in PR are causing those. > > On Tue, Dec 10, 2024 at 10:06 PM Evan Rusackas ***@***.***> > wrote: > >> Thanks for the quick rebase! Looks like there are some test failures on >> CI, but I'm not sure if they're related to the change or not. >> >> — >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/superset/pull/28203#issuecomment-2532891880>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AAVDI5L5ZIMNB7ULZLOUWQD2E5JWPAVCNFSM6AAAAABTL2O7FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZSHA4TCOBYGA> >> . >> You are receiving this because you were mentioned.Message ID: >> ***@***.***> >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
