mistercrunch commented on code in PR #31447:
URL: https://github.com/apache/superset/pull/31447#discussion_r1884565522
##########
superset/utils/hashing.py:
##########
@@ -21,7 +21,7 @@
def md5_sha_from_str(val: str) -> str:
- return hashlib.md5(val.encode("utf-8")).hexdigest()
+ return hashlib.md5(val.encode("utf-8")).hexdigest() # noqa: S324
Review Comment:
Seems this would break a bunch of calls as md5_sha_from_str is used
throughout the codebase (few dozen calls). Also I think this hash is for
internal use, not to secure things (?) Might also break things if we assume a
deterministic hash anywhere...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
