kgabryje opened a new pull request, #31472:
URL: https://github.com/apache/superset/pull/31472

   ### SUMMARY
   After upgrading the Tooltip component to antd5, tooltips were covering the 
date selector in horizontal native filters bar and preventing clicking on the 
filter.
   This PR fixes it by removing `getPopupContainer` prop from Tooltip, which 
was introduced in https://github.com/apache/superset/pull/24617 to fix an issue 
with tooltip position when user scrolls the page.
   Apparently Antd v5 fixed this behaviour and we no longer need to pass 
`getPopupContainer`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/user-attachments/assets/a7b21916-3ee3-427e-abc4-46b59ec40629
   
   After:
   
   
https://github.com/user-attachments/assets/6a2b734f-4c5d-4156-b558-027c4506b879
   
   ### TESTING INSTRUCTIONS
   1. Add a date native filter
   2. Set a date
   3. Verify that the tooltip is not covering the filter control and that its 
placement doesn't change when you scroll
   4. Make sure that it works as expected both in horizontal and vertical 
filter bar
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to