mistercrunch commented on code in PR #31489:
URL: https://github.com/apache/superset/pull/31489#discussion_r1889147392
##########
Dockerfile:
##########
@@ -21,12 +21,12 @@
ARG PY_VER=3.10-slim-bookworm
# If BUILDPLATFORM is null, set it to 'amd64' (or leave as is otherwise).
-ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
+ARG TARGET_BUILDPLATFORM=${BUILDPLATFORM:-amd64}
Review Comment:
would `ARG
TARGET_BUILDPLATFORM=${TARGET_BUILDPLATFORM:-${BUILDPLATFORM:-amd64}}` be
better? - haven't tested it?
I think it would provide a default if somehow both `TARGET_BUILDPLATFORM`
and `BUILDPLATFORM` are not in context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
