betodealmeida commented on PR #31486: URL: https://github.com/apache/superset/pull/31486#issuecomment-2549511704
@villebro there are roughly two reasons why we parse SQL in Superset: 1. To extract referenced tables (enforcing data access roles, for example); and 2. To modify the query (enforcing RLS, for example). The feature from this PR falls in category 2. I think that any functionality in that category should always be optional, since there are always security and correctness concerns when modifying a query. So I would propose the following: 5.0: add the feature flag, default to false. 6.0: move the feature flag to a configuration option, default to false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
