ERGO1995 opened a new pull request, #31565:
URL: https://github.com/apache/superset/pull/31565
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Added a LOADERS variable in the configuration files config.py and
superset_config.py:
- config.py default value → LOADERS = [{"src":
"/static/assets/images/loading.gif"}]
- superset_config.py → LOADERS = [{"src":
"/static/assets/images/YOUR_GIF.gif"}] (for exemple)
Managed the loader in Superset's base HTML skeleton:
- superset/superset/templates/superset/basic.html
Retrieved the custom loader in Superset API endpoints:
- superset/superset/views/core.py → Added an endpoint to retrieve the
loader from the configuration file.
Managed the loader in Superset's React.js elements:
- superset/superset-frontend/src/components/Loading/index.tsx → Fetches
the custom loader via the new endpoint.
I'm very new to Superset and the open-source world, and this is my first
attempt. I'm open to any advice on how to make this cleaner if needed :)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
Don't setup the LOADERS in superset_config.py file to see the default
loader. Then add tyour custom gif to see the difference.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
