dosubot[bot] commented on issue #31585: URL: https://github.com/apache/superset/issues/31585#issuecomment-2557410916
<!-- Greeting --> Hello @cougrimes! I'm here to help you with any bugs, questions, or contributions. Let's tackle this issue together! <!-- Answer --> The issue you're experiencing with the 'Time column' filter not respecting the 'Sort Filter Values' option in Superset seems to be related to the implementation of sorting logic for filter values. The current implementation of the 'Time column' filter uses a `Select` component to display options, but there is no specific mention of sorting logic being applied to these options in the available code snippets <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/filters/components/TimeColumn/index.ts)</sup><sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/filters/components/TimeColumn/TimeColumnFilterPlugin.tsx)</sup>. To address this, you might need to check if the sorting logic is correctly implemented in the `Select` component or if additional logic is required to sort the options based on the Column Label or Column Name. It could be beneficial to review the `onSortChanged` function and ensure it is correctly updating the state to reflect the desired sorting order <sup>[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx)</sup>. If the sorting logic is not present or not functioning as expected, you may need to implement custom sorting logic within the `handleChange` function or wherever the options are being set for the `Select` component. This would involve sorting the `options` array before it is passed to the `Select` component, based on your preferred criteria (Column Label first, then Column Name if no label is provided). <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* --- <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=hallucination) | [Other](https://app.dosu.dev/response-feedback/68dff212-3dbe-4867-abe2-a66d718ec73d?feedback_type=other)</sup> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
