landryb commented on PR #30134:
URL: https://github.com/apache/superset/pull/30134#issuecomment-2565454323
testing the PR here outside of the docker context (eg pip install from that
github branch branch, rebuild the assets with BASE_PATH set), that work is much
welcome.
some notes so far.. i think it should be mentioned that APP_ICON and FAVICON
needs BASE_PATH prepended, otherwise it generates 404's here with the default
value from `config.py`
looking a bit more at the code/PR, all assets below STATIC_ASSETS_PREFIX
also need to default to BASE_PATH ? that fixes the FAVICON while here.
with this config the superset homepage loads fine with all its
assets/images/favicon:
```
BASE_PATH = "/dashboards"
APP_ICON = BASE_PATH + "/static/assets/images/superset-logo-horiz.png"
STATIC_ASSETS_PREFIX = BASE_PATH
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
