ERGO1995 opened a new pull request, #31646:
URL: https://github.com/apache/superset/pull/31646

   ### SUMMARY
   I picked up an existing PR that was no longer progressing ([PR 
30318](https://github.com/apache/superset/pull/30318)). The idea is to make the 
language dynamic and configurable in the context of embedding a dashboard. To 
achieve this, I added a "locale" key in the urlParams, which allows passing the 
desired language code. Thus, in an embedding context, you just need to manage 
this code dynamically so that the user can view the dashboards in their 
preferred language.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   locale: 'en' :
   ![Capture d’écran 2024-12-30 à 17 09 
44](https://github.com/user-attachments/assets/0ddcd775-5b41-441c-b11e-3692033d67eb)
   
   locale: 'fr'
   ![Capture d’écran 2024-12-30 à 17 08 
58](https://github.com/user-attachments/assets/58b05181-82a2-4b9a-8be3-ba07ae4c0b82)
   
   
   ### TESTING INSTRUCTIONS
   You can modify the "locale" key here:
   ```
   <script>
       supersetEmbeddedSdk.embedDashboard({{
           id: "{dashboard_uuid}",
           supersetDomain: "{SUPERSET_URL}",
           mountPoint: document.getElementById("dashboard-container"),
           fetchGuestToken: () => "{token}",
           dashboardUiConfig: {{
               hideTitle: true,
               hideChartControls: false,
               urlParams: {{
                   startDate: '2024-01-01T00:00:00',
                   endDate: '2024-12-31T23:59:59',
                   locale: 'en'
               }}
           }}
       }});
   </script>
   ```
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to