korbit-ai[bot] commented on code in PR #31623:
URL: https://github.com/apache/superset/pull/31623#discussion_r1900450043
##########
superset-frontend/src/components/DropdownSelectableIcon/index.tsx:
##########
@@ -41,10 +41,10 @@ export interface DropDownSelectableProps extends
Pick<MenuProps, 'onSelect'> {
}
const StyledDropdownButton = styled(DropdownButton as FC<DropdownButtonProps>)`
- button.ant-btn:first-of-type {
+ button.antd5-btn:first-of-type {
display: none;
}
- > button.ant-btn:nth-of-type(2) {
+ > button.antd5-btn:nth-of-type(2) {
Review Comment:
### Invalid Ant Design v5 Button Class Names <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The CSS selector 'antd5-btn' is incorrect. Ant Design v5 uses the class name
'ant-btn' for buttons, not 'antd5-btn'.
###### Why this matters
The styled components won't properly target and style the buttons because
the CSS selectors are targeting non-existent classes, breaking the intended
button styling functionality.
###### Suggested change
Replace 'antd5-btn' with 'ant-btn' in both CSS selectors:
```typescript
button.ant-btn:first-of-type {
display: none;
}
> button.ant-btn:nth-of-type(2) {
```
</details>
###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help
Korbit improve your reviews.
<!--- korbi internal id:ef588f7d-3243-4be4-954b-05781dfb56f2 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
