sule26 commented on code in PR #31688:
URL: https://github.com/apache/superset/pull/31688#discussion_r1901256405
##########
helm/superset/README.md:
##########
@@ -66,7 +66,7 @@ On helm this can be set on
`extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| envFromSecret | string | `"{{ template \"superset.fullname\" . }}-env"` |
The name of the secret which we will use to populate env vars in deployed pods
This can be useful for secret keys, etc. |
| envFromSecrets | list | `[]` | This can be a list of templated strings |
| extraConfigMountPath | string | `"/app/configs"` | |
-| extraConfigs | object | `{}` | Extra files to mount on `/app/pythonpath` |
+| extraConfigs | object | `{}` | Extra files to mount on `/app/configs` |
Review Comment:
I think the part about mounting paths could use some clarification.
`extraConfigMountPath` is exclusively for mounting extraConfigs.
`configMountPath` , on the other hand, is where both `extraSecrets` and
`configOverrides` will be mounted.
This distinction might not be immediately obvious and could lead to
confusion. It might help to make this more explicit in the documentation or
code comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
