villebro commented on PR #31622: URL: https://github.com/apache/superset/pull/31622#issuecomment-2571385279
@hainenber sorry about the back and forth, but reading the docs for [find_spec](https://docs.python.org/3.12/library/importlib.html#importlib.util.find_spec), and I don't believe it raises `ImportError` if the spec is not found. It appears there's the possibility of it raising `ValueError`, though. So maybe change it to check for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
