michael-s-molina commented on code in PR #31582:
URL: https://github.com/apache/superset/pull/31582#discussion_r1907475559


##########
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##########
@@ -255,13 +243,16 @@ function saveExploreColorScheme(
   cy.wait('@chartUpdate');
 }
 
+// FIXME: Skipping some tests as ECharts are rendered using Canvas and we 
cannot inspect the elements

Review Comment:
   Yeah, that's a good suggestion. One option I can think of to overcome the 
ECharts canvas problem and be able to identify color changes would be to use 
the Word Cloud plugin which is pure HTML. I believe the solution for this 
problem should be resolved in a follow-up PR. I already sent a message to 
@geido about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to