geido commented on code in PR #31575:
URL: https://github.com/apache/superset/pull/31575#discussion_r1908598879
##########
superset-frontend/src/components/Label/index.tsx:
##########
@@ -25,6 +25,8 @@ import {
import { Tag } from 'src/components';
Review Comment:
If you look in `src/components/index.ts` you will see that `Tag` is being
exported directly from `antd`, which is the older version of Ant Design. What I
am proposing here is to use what we have in `src/components/Tags/Tag` which is
already upgraded to Ant Design 5. Not sure if any modifications are necessary
to fit that in your code, just saying that we should not be pulling from older
`antd` version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
