dosubot[bot] commented on issue #31767: URL: https://github.com/apache/superset/issues/31767#issuecomment-2579924930
<!-- Answer --> The behavior you're experiencing, where the save modal closes if no changes are made to a query in a new tab, might be related to how the `SaveQuery` component handles the save action. The modal is designed to close when the `onSaveWrapper` function is called, which includes logging the save action and then closing the modal. However, if no changes are detected, the modal might be closing prematurely due to the logic that determines whether a save action is necessary <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx)</sup>. Unfortunately, I couldn't find specific details in the repository about how changes are detected in a new tab or if there's a condition that prevents the modal from closing when no changes are made. It might be worth investigating the logic in the `SaveQuery` component further to see if there's a condition or flag that could be adjusted to prevent the modal from closing in this scenario. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* --- <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=hallucination) | [Other](https://app.dosu.dev/response-feedback/0715c149-d921-4a86-aa7c-9406cf3b4a83?feedback_type=other)</sup> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
