dankor commented on PR #29573: URL: https://github.com/apache/superset/pull/29573#issuecomment-2586462609
Hi @michael-s-molina ! Thanks for the review. I have answered all comments. > Could you update the PR description to reflect the latest changes with a clear description of why the change is needed? I have updated to support uuid along with id. > Could you add tests for the change? Sure, I didn't add them because I didn't find similar in the similar [PR](https://github.com/apache/superset/pull/13352). So I tried to keep my PR as close to the [similar one](https://github.com/apache/superset/pull/13352) as possible in order to get it merged too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
