eschutho commented on code in PR #31840:
URL: https://github.com/apache/superset/pull/31840#discussion_r1915640919
##########
tests/integration_tests/reports/alert_tests.py:
##########
@@ -184,9 +265,42 @@ def _mocked_execute_query() -> None:
execute_query_mock.side_effect = _mocked_execute_query
execute_query_mock.__name__ = "mocked_execute_query"
- command = AlertCommand(report_schedule=mocker.Mock())
+ command = AlertCommand(report_schedule=mocker.Mock(),
execution_id=uuid.uuid4())
with suppress(AlertQueryError):
command.validate()
# Should match the value defined in superset_test_config.py
assert execute_query_mock.call_count == 3
+
+
+def test_get_alert_metadata_from_object(
+ mocker: MockerFixture,
+ app_context: AppContext,
+ get_user,
+) -> None:
+ from superset.commands.report.alert import AlertCommand
+ from superset.reports.models import ReportSchedule
+
+ app.config["ALERT_REPORTS_EXECUTE_AS"] = [ExecutorType.OWNER]
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
