Re: [PR] feat: old Firebolt dialect [superset]

Tue, 14 Jan 2025 16:05:47 -0800 


korbit-ai[bot] commented on code in PR #31849:
URL: https://github.com/apache/superset/pull/31849#discussion_r1915771482


##########
superset/config.py:
##########
@@ -74,6 +74,8 @@
     from superset.models.dashboard import Dashboard
     from superset.models.slice import Slice
 
+    DialectExtensions = dict[str, Dialects | type[Dialect]]

Review Comment:
   ### Redundant redefinition of `DialectExtensions` outside the `if 
TYPE_CHECKING:` block. <sub>![category Readability and 
Maintainability](https://img.shields.io/badge/Readability%20and%20Maintainability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   &#8203;
   
   The redefinition of `DialectExtensions` outside the `if TYPE_CHECKING:` 
block appears redundant. Consider removing this redefinition unless it serves a 
specific purpose.
   
   
   </details>
   
   ###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help 
Korbit improve your reviews.
   
   
   <!--- korbi internal id:14916704-b62f-4e5d-9533-7c1c83e057a8 -->
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to