mistercrunch commented on PR #31811: URL: https://github.com/apache/superset/pull/31811#issuecomment-2591549791
Hey I don't want to derail here but somehow as part of my extremely large "theming PR" I somehow took on completely refactoring `Alert` and `ErrorAlert` into something much simpler, vanilla antd, that includes a `compact` prop for this type of stuff. https://github.com/apache/superset/pull/31590/files#diff-0e958cf2ea1bc7da177b24b9cfe5aef75308a080f22e2a0cada374ade11ba2cfR121-R140 I'm working at breaking down the PR into smaller chunks, but wondering whether it may make sense to align here. Somehow there are a lot of different ErrorAlert derivatives or components that should in theory BE and ErrorAlert but don't compose things as expected. Wondering if it'd be reasonable to bring in the Alert/ErrorAlert parts of my PR in here, though it may be a bit of a surgery. Clearly on a merge conflict collision here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
