geido commented on PR #31858: URL: https://github.com/apache/superset/pull/31858#issuecomment-2593398152
From some functional testing: - A bit of an edge case but the error looks like it is not correctly padded in full page width <img width="1511" alt="Screenshot 2025-01-15 at 17 26 57" src="https://github.com/user-attachments/assets/1850f835-0c54-4041-9edf-c29f7743ce78"; /> - Is a chart failure considered a warning? <img width="771" alt="Screenshot 2025-01-15 at 17 28 55" src="https://github.com/user-attachments/assets/52fe47dd-0463-4934-bdef-69b2e707d028"; /> - Same, for a chart in Explore. I am thinking these should probably be errors. <img width="1500" alt="Screenshot 2025-01-15 at 17 30 49" src="https://github.com/user-attachments/assets/64ceafad-326c-4844-b5a0-a98627dac81d"; /> - The positioning of the icon on the left of the text looks off. - In general, the text color of these alerts seem to stick out a bit too much. I know we want be as vanilla as possible but I'd like to hear @kasiazjc opinion too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
