Antonio-RiveroMartnez commented on issue #30592: URL: https://github.com/apache/superset/issues/30592#issuecomment-2596861757
Hey all! My two cents on this: 1. All Human dates should be handled either by the current library or some extra addition of better ones, but we should not be handling specific strings like "Prior" etc, otherwise maintaining this API can quickly become cumbersome. Even more, when we have already things like "ago" in our code base. 2. This API is extensively used in Superset and thus, changes on it would be considered breaking changes, for example, right now `Last 2 Hours` is expected to take the relative start of `today`, changing this could break existing charts/dashboards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
