alexandrusoare commented on PR #31867:
URL: https://github.com/apache/superset/pull/31867#issuecomment-2596917651

   > Hey @alexandrusoare , thanks for taking care of this.
   > 
   > I left a [comment on the 
issue](https://github.com/apache/superset/issues/30592#issuecomment-2596861757) 
itself, but IMHO we should instead have a look at the library that's parsing 
the human readable dates 
[here](https://github.com/apache/superset/blob/master/superset/utils/date_parser.py#L67)
 and see if there's something we can address there instead or if there's a 
limitation on such library etc.
   
   Hey @Antonio-RiveroMartnez , at first I was afraid of overcomplicating stuff 
as adding special queries for words like "prior", "start of" etc as well, and I 
tried to follow the trail to the exact issue. I think and I am not 100% sure, 
the library doesn't recognize correctly words like "start of", "end of", "last 
2 minutes", once I saw that the error is related to the library, I decided to 
take care of things like this. But I will have a second look on the library and 
let you know what are my discoveries and thoughts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to