rusackas commented on code in PR #31895:
URL: https://github.com/apache/superset/pull/31895#discussion_r1919308764
##########
.pre-commit-config.yaml:
##########
@@ -52,14 +52,6 @@ repos:
- id: trailing-whitespace
exclude: ^.*\.(snap)
args: ["--markdown-linebreak-ext=md"]
- - repo: local
- hooks:
- - id: eslint
- name: eslint
- entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@"
| sed "s|superset-frontend/||g")'
Review Comment:
@mistercrunch this sed business seemed to be causing a lot of errors around
missing files and whatnot. Is it a problem to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
