betodealmeida commented on code in PR #31889:
URL: https://github.com/apache/superset/pull/31889#discussion_r1920368032


##########
tests/unit_tests/utils/date_parser_tests.py:
##########
@@ -276,6 +291,44 @@ def test_get_since_until_instant_time_comparison_enabled() 
-> None:
     assert result == expected
 
 
+@patch("superset.utils.date_parser.parse_human_datetime")
+def test_previous_calendar_quarter(mock_parse):
+    today = datetime(2023, 1, 15)

Review Comment:
   We've been using `freezegun` for this in tests, something like:
   
   ```python
   with freezegun.freeze_time("2023-01-15"):
       result = get_since_until("previous calendar quarter")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to