mistercrunch commented on code in PR #31796:
URL: https://github.com/apache/superset/pull/31796#discussion_r1920672176
##########
docker-compose.yml:
##########
@@ -89,6 +89,8 @@ services:
restart: unless-stopped
ports:
- 8088:8088
+ # When in cypress-mode ->
+ - 8081:8081
Review Comment:
One thing that's kind of good with using a different port, is that firing up
Cypress against `docker compose up` will fail as it's looking for Superset on
8081, forcing the user to stop docker-compose and to fire it up properly
`CYPRES_CONFIG=true docker-compose up`, meaning it enforces having the right
backend, with the right test sets and examples loaded up, preventing some
confusion around using the wrong backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
