eschutho commented on code in PR #30949:
URL: https://github.com/apache/superset/pull/30949#discussion_r1920882370
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -314,15 +314,7 @@ export function transformSeries(
opacity: opacity * areaOpacity,
}
: undefined,
- emphasis: {
- // bold on hover as required since 5.3.0 to retain backwards feature
parity:
- //
https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart
- // TODO: should consider only adding emphasis to currently hovered series
- lineStyle: {
- width: 'bolder',
Review Comment:
Is it ok to remove it? It looks like the echarts community didn't like the
look of it on the line chart, so they removed it. It just seems more
distracting than anything on the line chart imo. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
