nsivarajan commented on code in PR #30284:
URL: https://github.com/apache/superset/pull/30284#discussion_r1920966817
##########
superset/async_events/async_query_manager.py:
##########
@@ -87,11 +90,9 @@ def get_cache_backend(
if cache_type == "RedisSentinelCache":
return RedisSentinelCacheBackend.from_config(cache_config)
- # TODO: Deprecate hardcoded plain Redis code and expand cache backend
options.
- # Maintain backward compatibility with 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG'
until it is deprecated. # noqa: E501
- return redis.Redis(
- **config["GLOBAL_ASYNC_QUERIES_REDIS_CONFIG"], decode_responses=True
- )
+ # TODO: Expand cache backend options.
+ # Removed support for deprecated 'GLOBAL_ASYNC_QUERIES_REDIS_CONFIG' as it
is no longer needed. # noqa: E501
Review Comment:
Thank you! I’ve included the changes in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
