geido commented on code in PR #31860:
URL: https://github.com/apache/superset/pull/31860#discussion_r1925487213
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -113,7 +113,7 @@ const SqlEditorLeftBar = ({
'schema',
]);
- const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
+ const [_emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
Review Comment:
I am not sure that we need this. It looks that originally the [PR that
introduced this
](https://github.com/apache/superset/pull/19598/files#diff-bbf91464669d98b9e120f57ce26155804f7238a277fcc30c0d805a943f6c73edR190)
was just meant to show some alternate text. I did some testing and I could not
see anything breaking with just removing this entirely.
##########
superset-frontend/package-lock.json:
##########
@@ -1702,15 +1702,18 @@
}
},
"node_modules/@babel/helper-string-parser": {
- "version": "7.24.8",
- "resolved":
"https://registry.npmjs.org/@babel/helper-string-parser/-/helper-string-parser-7.24.8.tgz";,
- "integrity":
"sha512-pO9KhhRcuUyGnJWwyEgnRJTSIZHiT+vMD0kPeD+so0l7mxkMT19g3pjY9GTnHySck/hDzq+dtW/4VgnMkippsQ==",
+ "version": "7.25.9",
Review Comment:
Just double-checking. Are these bumps necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
