mistercrunch commented on code in PR #30134:
URL: https://github.com/apache/superset/pull/30134#discussion_r1930002094
##########
Dockerfile:
##########
@@ -62,9 +62,9 @@ RUN
--mount=type=bind,source=./superset-frontend/package.json,target=./package.j
--mount=type=cache,target=/root/.cache \
--mount=type=cache,target=/root/.npm \
if [ "$DEV_MODE" = "false" ]; then \
- npm ci; \
+ npm ci; \
Review Comment:
Why removing/altering the indentation here? Guessing maybe your IDE did it?
Indentation may not be perfect/consistent in Dockerfile(s) but we should keep
some indent on if / else blocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
