mistercrunch opened a new pull request, #31996: URL: https://github.com/apache/superset/pull/31996
While reviewing https://github.com/apache/superset/pull/30134 which seemed to make heavy use of `getBootstrapData`, I realized that it's usage is occurs 21 times across the codebase while it may be a fairly expensive operation (JSON.parse on an object that may be significant in size at times (?)). Now it's easy to cache the result in a closure and ensure it happens only once per SPA-load, but opening this as a DRAFT as we probably already store it in many places. Tradeoff here is compute VS memory, and clearly we need in memory somewhere, but probably in most cases, already have it in the state app somewhere. Ideally the app would read it once and make it available in its state, as opposed to different modules calling it on-demand... PR is more of a request for comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
