eschutho commented on code in PR #31333: URL: https://github.com/apache/superset/pull/31333#discussion_r1931202208
########## superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts: ########## @@ -290,12 +291,24 @@ export default function transformProps( const showValueIndexesB = extractShowValueIndexes(rawSeriesB, { stack, }); + + const metricMapFunc = (metric: string | AdhocMetric) => { + if (metric.hasOwnProperty('label')) { + return (metric as AdhocMetric).label; Review Comment: Ah, yes. How should that function work with the verboseMap, though? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org