chakilamsuryat commented on PR #32012: URL: https://github.com/apache/superset/pull/32012#issuecomment-2623423417
> we only show that this isn't possible after a user may have already made edits on an existing dashboard and trying to save then we let them know that they can't save? That seems pretty bad for the user. Also if they save as a new dashboard, then anything shared will have to be reshared with users. Few options: 1. Can show on UI over dashboard like for the new instructions initially for some time. So of customer is ok with name change to valid name then he can proceed. Else if ok with new dashboard, can copy previous dashboard, make changes and save with valid name. 2. We can try enabling this validation for suppose created greater than or equal to today dashboards only. We can think of such options for user experience. But as issue is related security vulnerability, I think some validation at input should be there as part of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
