korbit-ai[bot] commented on code in PR #32041:
URL: https://github.com/apache/superset/pull/32041#discussion_r1935684855
##########
superset/db_engine_specs/TDengine.py:
##########
@@ -0,0 +1,19 @@
+# TDengine driver for Apache SuperSet
+from superset.db_engine_specs.base import BaseEngineSpec
+
+class TDengineEngineSpec(BaseEngineSpec):
+ engine = "taosws"
+ engine_name = "TDengine"
+ max_column_name_length = 64
+ default_driver = "taosws"
+ sqlalchemy_uri_placeholder =
("taosws://user:password@host:port/dbname[?key=value&key=value...]")
Review Comment:
### Insecure Credential Example in URI Placeholder <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The connection string example includes 'user:password' which could encourage
users to include actual credentials in code or configuration files.
###### Why this matters
Even example credentials in placeholder strings can lead to security issues
if users copy-paste them as templates, potentially committing actual
credentials to version control.
###### Suggested change ∙ *Feature Preview*
```python
sqlalchemy_uri_placeholder =
"taosws://{username}:{password}@host:port/dbname[?key=value&key=value...]"
```
or
```python
sqlalchemy_uri_placeholder =
"taosws://username:******@host:port/dbname[?key=value&key=value...]"
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dce536b8-1807-4b32-8018-5604ca915476?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:9fc09c6e-7d28-41fa-9f7b-8de46e196c00 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
