mistercrunch commented on issue #26319: URL: https://github.com/apache/superset/issues/26319#issuecomment-2633496582
Yes, seems https://github.com/apache/superset/pull/30134 is becoming a step in the right direction. Only concern there is around preventing people from adding new URLs without using the right wrapper, and having everything works (the app, CI, ...) but breaks when specifying an approot. Maybe modifying e2e test suite to run with an approot would be sufficient(?) Coverage isn't complete though. Another option is to label the feature as in `beta` for now until we can prevent regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
