giftig commented on code in PR #32170: URL: https://github.com/apache/superset/pull/32170#discussion_r1945270657
########## superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/types.ts: ########## @@ -36,7 +36,9 @@ export type BoxPlotFormDataWhiskerOptions = | 'Tukey' | 'Min/max (no outliers)' | '2/98 percentiles' - | '9/91 percentiles'; + | '5/95 percentiles' + | '9/91 percentiles' + | '10/90 percentiles'; Review Comment: Seems like ab it of a flaky way to handle it but it's not new code so fair enough :+1: ########## superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/types.ts: ########## @@ -36,7 +36,9 @@ export type BoxPlotFormDataWhiskerOptions = | 'Tukey' | 'Min/max (no outliers)' | '2/98 percentiles' - | '9/91 percentiles'; + | '5/95 percentiles' + | '9/91 percentiles' + | '10/90 percentiles'; Review Comment: Seems like a bit of a flaky way to handle it but it's not new code so fair enough :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
