kgabryje commented on code in PR #31634: URL: https://github.com/apache/superset/pull/31634#discussion_r1951083523
########## superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx: ########## @@ -17,9 +17,9 @@ * under the License. */ -import { mount, shallow } from 'enzyme'; import { triggerResizeObserver } from 'resize-observer-polyfill'; import { promiseTimeout, WithLegend } from '@superset-ui/core'; +import { render } from '@testing-library/react'; Review Comment: please import from `spec/helpers/testing-library` instead. Applies to all files - you won't need to import additional stuff like `@testing-library/jest-dom` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org