sadpandajoe commented on code in PR #32218:
URL: https://github.com/apache/superset/pull/32218#discussion_r1953291193
##########
superset-frontend/src/components/Datasource/utils.js:
##########
@@ -121,7 +121,7 @@ export function updateColumns(prevCols, newCols,
addSuccessToast) {
export async function fetchSyncedColumns(datasource) {
const params = {
- datasource_type: datasource.type,
+ datasource_type: datasource.type || datasource.datasource_type,
Review Comment:
@michael-s-molina I wonder if this is similar to the line below where we
have `database.database_name` or `database.name`. Maybe the API is returning
`datasource_type` vs `type` which could be whats causing an issue. Also I do
agree with Korbit that we should probably add null check and we should probably
add tests for `fetchSyncedColumns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
