korbit-ai[bot] commented on code in PR #32253:
URL: https://github.com/apache/superset/pull/32253#discussion_r1955047130
##########
superset/utils/pandas_postprocessing/histogram.py:
##########
@@ -60,8 +60,7 @@ def histogram(
# convert the bin edges to strings
bin_edges_str = [
- f"{int(bin_edges[i])} - {int(bin_edges[i+1])}"
- for i in range(len(bin_edges) - 1)
+ f"{bin_edges[i]} - {bin_edges[i+1]}" for i in range(len(bin_edges) - 1)
Review Comment:
Thanks for the clarification @michael-s-molina. If formatting is handle in
the frontend then it makes sense to keep full precision here. Please do make
sure the frontend feature handles very long decimal precision properly to avoid
unwieldy labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
