korbit-ai[bot] commented on code in PR #32231: URL: https://github.com/apache/superset/pull/32231#discussion_r1958644156
########## superset/config.py: ########## @@ -1916,6 +1916,15 @@ class ExtraDynamicQueryFilters(TypedDict, total=False): CATALOGS_SIMPLIFIED_MIGRATION: bool = False +# When updating a DB connection or manually triggering a resync, the command +# happens in sync mode. If you have a celery worker configured, it's recommended +# to change below config to ``True`` to run this process in async mode. A DB +# connection might have hundreds of catalogs with thousands of schemas each, which +# considerably increases the time to process it. Running it in async mode prevents +# keeping a web API call open for this long. +RESYNC_DB_PERMISSIONS_IN_ASYNC_MODE: bool = False Review Comment: Thank you @Vitor-Avila for the clarification. I understand the need to ensure that the application's critical functionality remains consistently available, especially in deployments where Celery workers might not be running. While I still stand by the suggestion for a feature that checks the status of Celery workers and adjusts the sync mode accordingly, I understand and respect your considerations for existing deployments and the importance of not changing their behavior unexpectedly. I appreciate your thoughtful responses and look forward to further improvements on this feature in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
