hainenber commented on code in PR #32310:
URL: https://github.com/apache/superset/pull/32310#discussion_r1962835058
##########
superset/databases/api.py:
##########
@@ -1002,15 +1003,16 @@ def table_metadata(self, pk: int) -> FlaskResponse:
parameters = QualifiedTableSchema().load(request.args)
except ValidationError as ex:
raise InvalidPayloadSchemaError(ex) from ex
-
- table = Table(parameters["name"], parameters["schema"],
parameters["catalog"])
+ table_name = str(parameters["name"])
+ ispartitioned_table, partition_fields =
DatabaseDAO.is_odps_partitioned_table(database,table_name)
Review Comment:
I mean, `ispartitioned` doesn't follow usual Python snake-case naming
convention. It usually goes like `is_partitioned_table`, fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
