hainenber commented on code in PR #21364:
URL: https://github.com/apache/superset/pull/21364#discussion_r1962975392


##########
superset/db_engine_specs/snowflake.py:
##########
@@ -274,6 +275,7 @@ def build_sqlalchemy_uri(
                 query={
                     "role": parameters.get("role"),
                     "warehouse": parameters.get("warehouse"),
+                    "application": os.environ.get("SF_PARTNER", "SUPERSET"),

Review Comment:
   can we rename the env var to something more self-explained, like 
`SNOWFLAKE_PARTNER_APPLICATION_ID`. A bit verbose but I think everybody can 
understand straightaway what it means.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to