korbit-ai[bot] commented on code in PR #32333: URL: https://github.com/apache/superset/pull/32333#discussion_r1964073452
########## scripts/eslint.sh: ########## @@ -0,0 +1,25 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e + +script_dir="$(dirname "$(realpath "$0")")" +root_dir="$(dirname "$script_dir")" +frontend_dir=superset-frontend + +cd "$root_dir/$frontend_dir" +npm run eslint -- "${@//$frontend_dir\//}" Review Comment: ### Missing error context for critical operations <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The script uses 'set -e' but lacks error handling around critical directory change and command execution operations. ###### Why this matters While 'set -e' will exit on error, it provides no context about what failed, making debugging harder in case the directory doesn't exist or npm command fails. ###### Suggested change ∙ *Feature Preview* Add error handling with informative messages: ```bash if ! cd "$root_dir/$frontend_dir" 2>/dev/null; then echo "Error: Failed to change to frontend directory: $root_dir/$frontend_dir" >&2 exit 1 fi if ! npm run eslint -- "${@//$frontend_dir//}"; then echo "Error: ESLint command failed" >&2 exit 1 fi ``` </details> <sub> [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f0355108-7f25-43b2-beb0-b7fbc5774204?suggestedFixEnabled=true) 💬 Chat with Korbit by mentioning @korbit-ai. </sub> <!--- korbi internal id:c7253415-4509-416b-bb00-a11cdbc93470 --> ########## scripts/eslint.sh: ########## @@ -0,0 +1,25 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e + +script_dir="$(dirname "$(realpath "$0")")" +root_dir="$(dirname "$script_dir")" +frontend_dir=superset-frontend + +cd "$root_dir/$frontend_dir" Review Comment: ### Missing directory existence check <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The script doesn't verify the existence of the frontend directory before attempting to change into it. ###### Why this matters If the superset-frontend directory doesn't exist, the script will fail with an unclear error message, making it difficult to diagnose the issue. ###### Suggested change ∙ *Feature Preview* Add a check for the directory existence before changing into it: ```bash if [[ ! -d "$root_dir/$frontend_dir" ]]; then echo "Error: $frontend_dir directory not found in $root_dir" exit 1 fi cd "$root_dir/$frontend_dir" ``` </details> <sub> [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/490f83c5-082c-4a62-b015-83535c3c2295?suggestedFixEnabled=true) 💬 Chat with Korbit by mentioning @korbit-ai. </sub> <!--- korbi internal id:c79b2e6e-7633-4fab-b18b-a149f47ea9ca --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
