betodealmeida commented on code in PR #28627:
URL: https://github.com/apache/superset/pull/28627#discussion_r1964583631
##########
superset/db_engine_specs/databend.py:
##########
@@ -217,10 +217,11 @@ class DatabendConnectEngineSpec(BasicParametersMixin,
DatabendEngineSpec):
_function_names: list[str] = []
sqlalchemy_uri_placeholder = (
-
"databend://user:password@host[:port][/dbname][?secure=value&=value...]"
+
"databend://user:password@host[:port][/dbname][?sslmode=value&=value...]"
)
parameters_schema = DatabendParametersSchema()
- encryption_parameters = {"secure": "true"}
+ encryption_parameters = {"sslmode": "require"}
+ encryption_disable_parameters = {"sslmode": "disable"}
Review Comment:
Oh, this is nice! If it's not asking too much, can you add this to the
`BasicParametersMixin` as well, and update the logic of `build_sqlalchemy_uri`
and `get_parameters_from_uri` to use it?
##########
superset/db_engine_specs/databend.py:
##########
@@ -273,7 +276,10 @@ def get_parameters_from_uri(
) -> BasicParametersType:
url = make_url_safe(uri)
query = url.query
- if "secure" in query:
Review Comment:
Can we add a migration updating existing URLs to the new format? This way
upgrading Superset won't break any existing installations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
