maybedino opened a new pull request, #32348:
URL: https://github.com/apache/superset/pull/32348
### SUMMARY
This adds the missing SSH parameter to the clickhouse-connect engine.
Clickhouse engine makes copy of BasicParametersSchema instead of just
inheriting from it. Maybe that's not ideal, but I decided to keep it like this
and add the SSH parameter as well.
### TESTING INSTRUCTIONS
Add a new clickhouse database (with clickhouse-connect), the SSH option
should show up and work.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Fixes #28114
- [x] Required feature flags: Change SSH_TUNNELING to True
- [ ] Changes UI - (not really but the SSH toggle will show up now)
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
