Re: [PR] chore: Upgrade AG Grid to use tree shaking [superset]

Fri, 21 Feb 2025 15:11:02 -0800 


justinpark commented on code in PR #32334:
URL: https://github.com/apache/superset/pull/32334#discussion_r1966307562


##########
superset-frontend/src/components/GridTable/index.tsx:
##########
@@ -216,21 +231,16 @@ function GridTable<RecordType extends object>({
         `}
       >
         <AgGridReact
+          // TODO: migrate to Theme API - 
https://www.ag-grid.com/react-data-grid/theming-migration/
+          theme="legacy"

Review Comment:
   with this theme value, the existing ag-theme-quartz styles are broken.
   
![_DEV__Superset](https://github.com/user-attachments/assets/48cf5d8c-746c-4715-b395-c5ce0ed74f3c)
   
   Please migrate to theme api first to apply the theme name here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to