Mistuke opened a new issue, #32353:
URL: https://github.com/apache/superset/issues/32353

   ### Bug description
   
   #30284 removed `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` for 
`GLOBAL_ASYNC_QUERIES_CACHE_BACKEND`,
   however `GLOBAL_ASYNC_QUERIES_CACHE_BACKEND` even though it declares 
`CACHE_REDIS_USER` as a parameter  
https://github.com/apache/superset/blob/2c37ddb2f63d216665c8d81232500986281ccfc0/superset/config.py#L1755
 never passes the username down to the redis client 
    
https://github.com/apache/superset/blob/master/superset/async_events/cache_backend.py#L27
 which means the user/password pair is never correct.
   
   With `GLOBAL_ASYNC_QUERIES_REDIS_CONFIG` this was possible to do as it had 
the ability to pass kwargs directly to the redis client. Which means before 
this change it was possible to use secure username/password redis, but after 
this change it's not.
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [x] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to