rusackas commented on issue #32357: URL: https://github.com/apache/superset/issues/32357#issuecomment-2679081242
I would strongly advise against passing CSS through the iframe wall... CSS is good for some tweaks/overrides, but there is a whole vision (a SIP and a PR soon to merge) that are working toward *proper* systemic theming in Superset. When we get there, I'd be fine with passing a theme name/ID as a parameter, and/or revisiting the concept of passing CSS through as well, but for now, passing a big CSS palyoad into the iframe is risky business, and will _probably_ be an anti-pattern when we have proper theming support (finally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
